Repository navigation
Write out the issue links in comments rather than the shorthand - #689
Merged
Happypig375 merged 1 commit intoAug 4, 2026
Merged
Conversation
A comment saying #531 only resolves inside GitHub's own interface. Read from a checkout, from git log, or from an editor, it names neither the project nor anything reachable. On a pull request the shorthand is linked automatically, so it reads fine there; in a comment nothing links it. Seven of these, all in comments this branch's author wrote. The six that were already here -- #327 three times in InnerSimplifyTest, #254 and #311 in FractionSimplify, #170 in PatternTest -- are left alone; say the word and they can go the same way. Comments only. 4009 tests.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #689 +/- ##
==========================================
- Coverage 80.99% 80.42% -0.58%
==========================================
Files 155 156 +1
Lines 13687 12917 -770
Branches 1957 2122 +165
==========================================
- Hits 11086 10388 -698
+ Misses 1990 1921 -69
+ Partials 611 608 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Happypig375 asked for this — thanks for saying so.
A comment saying
#531only resolves inside GitHub's own interface. Read from a checkout, fromgit log, or from an editor, it names neither the project nor anything reachable. On a pull request the shorthand is linked automatically, so it reads fine there; in a comment nothing links it.Seven of these, all in comments I wrote:
Patterns.ExpandFactorize.csPatterns.Trigonometry.csIntegrationTest.csAlreadyFixedIssuesTest.csNumericsRegressionTest.csMultipleAngleTest.csThe six that were already here — 327 three times in
InnerSimplifyTest, 254 and 311 inFractionSimplify, 170 inPatternTest— are left alone, since they are not mine to restyle. Say the word and they can go the same way.Comments only, no behaviour. 4009 unit tests, none failing. I have noted the convention and will follow it from here.